Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st sound round for XPT2046 module. #284

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

allObjects
Copy link
Contributor

On branch xpt2046

Changes to be committed:
new file: datasheets/XPT2046.pdf
new file: devices/XPT2046.js
new file: devices/XPT2046.md

Markus Muetschard added 2 commits October 1, 2016 15:47
On branch xpt2046

Changes to be committed:
	new file:   datasheets/XPT2046.pdf
	new file:   devices/XPT2046.js
	new file:   devices/XPT2046.md
Changes to be committed:
	modified:   devices/XPT2046.md
@allObjects
Copy link
Contributor Author

Hi Gordon,

thanks for your personal lines and the gift with the last Tindie shipment. I means a lot to me - especially since I know that time is of the most precious good.

This - finally my first, hopefully complete - module request is for more to come: the ui modules that I announce a bit ago. I have them reworked/refactored back and forth and feel pretty ready to push them, because recent refactorings ended pretty much with the same code...

When I looked into the available ADS7843 resistive touchscreen controller, it was just not accurate enough... actually very off... depending on the orientation of the touchscreen in regard to top/left 0/0 coordinates. I published in the forum about it when I had to adopt a new display and touchscreen because the (ada)fruit one went bad with just sitting around... May be later I will also pub the resistive touchscreen Espruino-controller module, but it has lower priority compared to the ui modules.

The XPT2046 chip is from what I can see just a knockoff/rename/rebrand of the ADS7843 chiop... because it works with the ADS7843.js module.

For the XPT2046.md I have added a image, but just noticed that I forgot to 'pull it into' the md file... so you will see a second PR.

Furthermore, the .md inlcudes code for the calibration of the XPT2046 touchscreen controller. I hope it is in the right place (and format). If not let me know where to put...

Best regards, and thanks again for all your hard work

  • markus

PS did hear back from the Espruino pep / lightning talk application at the Stanford IT UnConference on Dec 8, mentioning, that it is still very early in planning state and I would be notified down the (time) line...

Changes to be committed:
	modified:   devices/XPT2046.md
@allObjects
Copy link
Contributor Author

Gordon, do not merge the pull request yet... some textual changes are still under way.

@gfwilliams
Copy link
Member

Hi, no problem! I really appreciate the hours it must take you to help people out on the forum :)

What you've done looks great - just let me know when you're ready to merge.

If you could link to /ADS7843 (the existing ADS7843 page) at the top, and cross-link back to your page from ADS7843.md, that would be really handy though - it might help people find your module if they were searching for the basic ADS7843.

I future, I'd try and avoid duplicating functionality wherever possible though. For other things, if there's an existing module, generally it's better to modify it to work better (even if that means re-writing but providing a fallback for existing users).

@gfwilliams
Copy link
Member

Hi - just wondering - are you ready for me to merge this in yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants