Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discussion: SetUI Q3 changes #2526

Closed
wants to merge 4 commits into from
Closed

discussion: SetUI Q3 changes #2526

wants to merge 4 commits into from

Commits on Jul 1, 2024

  1. Bangle_setUI_Q3: set custom handlers on any mode 

    TODO: Not thoroughly tested yet.

First discussed here around here:
espruino/BangleApps#3435 (comment)
    @thyttan
    thyttan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1ba083b View commit details
    Browse the repository at this point in the history

  2. Bangle_setUI_Q3: only add custom btn handler 

    This is maybe a quick fix. There could maybe be a bigger refactor to
handle btn watches in the same way as other handlers are added, where
they aren't added until we know which on we want to set (By
writing/overwriting e.g. `Bangle.touchHandler` and only actually set it
with `Bangle.on` at the end of the script).
    @thyttan
    thyttan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6567b77 View commit details
    Browse the repository at this point in the history

  3. Bangle_setUI_Q3: Make custom btn edge configurable 

    `btn` can be set like before, so backwards compatible I think.
But it can now also be an object on form
{fn: ()={}, edge: "rising/falling/both"}.
@gfwilliams has suggested another solution using callbacks in
espruino/BangleApps#3452 (comment)
The solution I opted for here for now follows the same coding
style of how the `type`/`mode` parameter of setUI can be
either a string or an object.
    @thyttan
    thyttan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8a3210c View commit details
    Browse the repository at this point in the history

  4. Bangle_setUI_Q3: Change default btn edge to rising 

    To make the ui feel snappier.

First discussed around here:
espruino/BangleApps#3435 (comment)
    @thyttan
    thyttan committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b978df5 View commit details
    Browse the repository at this point in the history