Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bttfclock #3646

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Bttfclock #3646

merged 6 commits into from
Nov 8, 2024

Conversation

NoobEjby
Copy link
Contributor

@NoobEjby NoobEjby commented Nov 6, 2024

My first watchface and code for the bangle.js v2.

Please let me know if something seems wrong

Copy link
Collaborator

@thyttan thyttan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some review comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file to "app.js".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file to "ChangeLog".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to "app-icon.js"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to "app.png"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to "screenshot.png".

"name": "Back To The Future",
"version": "0.01",
"description": "My favorit Garmin watchface",
"icon": "bttf_clock.png",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"icon": "bttf_clock.png",
"icon": "app.png",

"version": "0.01",
"description": "My favorit Garmin watchface",
"icon": "bttf_clock.png",
"screenshots": [{"url":"bttf_screenshot.png"}],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"screenshots": [{"url":"bttf_screenshot.png"}],
"screenshots": [{"url":"screenshot.png"}],

"supports": ["BANGLEJS2"],
"allow_emulator": true,
"storage": [
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"},
{"name":"bttfclock.app.js","url":"app.js"},

"allow_emulator": true,
"storage": [
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"},
{"name":"bttfclock.img","url":"bttf_clock_icon.js","evaluate":true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"name":"bttfclock.img","url":"bttf_clock_icon.js","evaluate":true}
{"name":"bttfclock.img","url":"app-icon.js","evaluate":true}

"id": "bttfclock",
"name": "Back To The Future",
"version": "0.01",
"description": "My favorit Garmin watchface",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description of the app as this will be the first thing a user reads about this clock.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link the readme so it's available on the app loader.

Suggested change
"description": "My favorit Garmin watchface",
"description": "The watch of Marty McFly",
"readme": "README.md",

@NoobEjby
Copy link
Contributor Author

NoobEjby commented Nov 8, 2024

Thanks @thyttan I saw the error in the flow, but it would have taken me a little longer to figure out without your help. I have made the changes and am crossing my fingers for it to work now :)

@thyttan
Copy link
Collaborator

thyttan commented Nov 8, 2024

Nice! The linter still complains about three variables that are never used (see the "Files changed" tab). Either remove them or comment them out and I think we should be good to go 👍

@thyttan
Copy link
Collaborator

thyttan commented Nov 8, 2024

Merging - thanks again!

@thyttan thyttan merged commit d18c0d2 into espruino:master Nov 8, 2024
1 check passed
@NoobEjby
Copy link
Contributor Author

Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants