-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bttfclock #3646
Bttfclock #3646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added some review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename file to "app.js".
apps/bttfclock/ChangeLog.log
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename file to "ChangeLog".
apps/bttfclock/bttf_clock_icon.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "app-icon.js"
apps/bttfclock/bttf_icon.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "app.png"
apps/bttfclock/bttf_screenshot.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to "screenshot.png".
apps/bttfclock/metadata.json
Outdated
"name": "Back To The Future", | ||
"version": "0.01", | ||
"description": "My favorit Garmin watchface", | ||
"icon": "bttf_clock.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"icon": "bttf_clock.png", | |
"icon": "app.png", |
apps/bttfclock/metadata.json
Outdated
"version": "0.01", | ||
"description": "My favorit Garmin watchface", | ||
"icon": "bttf_clock.png", | ||
"screenshots": [{"url":"bttf_screenshot.png"}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"screenshots": [{"url":"bttf_screenshot.png"}], | |
"screenshots": [{"url":"screenshot.png"}], |
apps/bttfclock/metadata.json
Outdated
"supports": ["BANGLEJS2"], | ||
"allow_emulator": true, | ||
"storage": [ | ||
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"}, | |
{"name":"bttfclock.app.js","url":"app.js"}, |
apps/bttfclock/metadata.json
Outdated
"allow_emulator": true, | ||
"storage": [ | ||
{"name":"BackToTheFuture.app.js","url":"BackToTheFuture.app.js"}, | ||
{"name":"bttfclock.img","url":"bttf_clock_icon.js","evaluate":true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"name":"bttfclock.img","url":"bttf_clock_icon.js","evaluate":true} | |
{"name":"bttfclock.img","url":"app-icon.js","evaluate":true} |
apps/bttfclock/metadata.json
Outdated
"id": "bttfclock", | ||
"name": "Back To The Future", | ||
"version": "0.01", | ||
"description": "My favorit Garmin watchface", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a short description of the app as this will be the first thing a user reads about this clock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link the readme so it's available on the app loader.
"description": "My favorit Garmin watchface", | |
"description": "The watch of Marty McFly", | |
"readme": "README.md", |
Thanks @thyttan I saw the error in the flow, but it would have taken me a little longer to figure out without your help. I have made the changes and am crossing my fingers for it to work now :) |
Nice! The linter still complains about three variables that are never used (see the "Files changed" tab). Either remove them or comment them out and I think we should be good to go 👍 |
Merging - thanks again! |
Thanks for the help |
My first watchface and code for the bangle.js v2.
Please let me know if something seems wrong