Poker Timer App

[ki9us]

Is it ok to add an app as a git submodule?

[thyttan]

Is it ok to add an app as a git submodule?

@gfwilliams probably knows best here.

[gfwilliams]

No, I'm afraid not. Because then we're unable to check on any changes - you could push an update, accidentally mess up the metadata.json and break the app loader for everyone, and we couldn't do anything apart from remove your app.

Sometimes we may need to make quite broad changes (maybe some API changes or we become aware of something your app is doing that's a problem) and we want to be able to make changes to a bunch of apps at once. If we have a bunch of submodules we're going to have to submit PRs to all the app owners who may/may not merge them and the whole thing becomes onworkable.

[ki9us]

I expect to push an update this week to fix some bugs:

• Unlock to vibrate/flash
• Screenshots in README
• Start app paused
• Indicate when paused
• 20-second warning

So you can just wait for that if you want.

[gfwilliams]

Sounds good. Please can you change the version number style to 0.01 (not 0.0.1) - I believe parts of the app loader expect it to be a number

[ki9us]

Ok. Do I need to do anything about these build errors?

Error: App pokertimer has no entrypoint
Error: App pokertimer has no JS icon

[gfwilliams]

Yes - it's because of:

 {"name":"timer.app.js","url":"app.js"},
    {"name":"timer.img","url":"app-icon.js","evaluate":true}

They should be {"name":"pokertimer... since the app is called pokertimer

[ki9us]

Try that. Just tested on hardware and seems ok.

[ki9us]

Here's the forked App Loader:

https://ki9us.github.io/BangleApps/?q=pokertimer

[gfwilliams]

Looks good to me - thanks!