Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0.02 #3588

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Update 0.02 #3588

merged 2 commits into from
Oct 14, 2024

Conversation

mjearlb
Copy link
Contributor

@mjearlb mjearlb commented Sep 25, 2024

0.02:

  • Removed HRV functionality
  • Added milliseconds to the timestamps

@thyttan
Copy link
Collaborator

thyttan commented Sep 25, 2024

Calling @ekwawu for feedback (as I understand it the hrv feature is used in a class they give at the university of Georgia).

@mjearlb
Copy link
Contributor Author

mjearlb commented Sep 26, 2024

Hi @thyttan - I am working on the continuation of the Capstone project which @ekwawu started. The HRV function is not accurate, so that's why I have removed it. I totally understand why you need approval first though. Thanks!

@thyttan
Copy link
Collaborator

thyttan commented Sep 28, 2024

Ok! When will you want to be using this in classes again? I.e. when would you like to see this merged? Do you have direct contact with @ekwawu and do you think he will respond here? If not I think we can go ahead anyway.

@mjearlb
Copy link
Contributor Author

mjearlb commented Oct 14, 2024

@thyttan I apologize, I must have missed your reply. @ekwawu has graduated, so might not be active on their account any more. I would like it merged soon so that we can get started programming the batch of watches we ordered.

Thank you for your help.

@thyttan thyttan merged commit 13d9828 into espruino:master Oct 14, 2024
1 check passed
@thyttan
Copy link
Collaborator

thyttan commented Oct 14, 2024

I merged it now. It will be available on the development app loader right away. It will probably be pushed to the official app loader in a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants