Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clkinfomsg: clockinfo for displaying messages count #3587

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

kamilkrz
Copy link
Contributor

Read and unread. This is proof of concept but mostly working.
Only nice to have would be handling messages that was read on phone (I believe if keep msgs is not set in android, messages read on phone trigger some kind of event for removing it from watch)

Nothing fancy

Copy link
Collaborator

@bobrippling bobrippling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the app! Had a few questions :)

apps/clkinfomsg/clkinfo.js Outdated Show resolved Hide resolved
apps/clkinfomsg/clkinfo.js Outdated Show resolved Hide resolved
if (msgAll === undefined) {
msgAll = "?";
}
info.items[0].emit("redraw");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here if items[1] is being displayed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some guidance - is there a chance to have context here about current CI is being shown? I don't like idea of refreshing all CI modules but in my opinion its best place to do it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - what we have is good, the bangle health clkinfo is similar:

function batteryUpdateHandler() { bangleItems[0].emit("redraw"); }
function stepUpdateHandler() { bangleItems[1].emit("redraw"); }

If you wanted, you could change the show function to note down which clkinfo is visible, then msgCounter could call .emit("redraw") on that, but I think what you have is fine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge, but feel free to open another PR if you want to tweak it :)

apps/clkinfomsg/clkinfo.js Outdated Show resolved Hide resolved
@bobrippling bobrippling merged commit 68191d9 into espruino:master Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants