Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pomoplus: increase size of fonts and buttons #3541

Merged
merged 8 commits into from
Sep 7, 2024

Conversation

thyttan
Copy link
Collaborator

@thyttan thyttan commented Aug 23, 2024

for legibility and ease of use.

Changes made primarily for the Bangle.js 2. I haven't run them on an actual Bangle.js 1 watch - only the emulator. The update can be tried here (please report back if you try!): https://thyttan.github.io/BangleApps/?id=pomoplus

@bruceblore @notEvil thoughts?

Edit: After measuring ram use it think it still fits on the Bangle.js 1.

@thyttan thyttan force-pushed the pomoplus branch 2 times, most recently from e394d1b to 1160409 Compare August 24, 2024 16:07
for legibility and ease of use.

Also center the images correctly with regards to their anchoring.
@pavelmachek
Copy link
Contributor

Unrelated to this, I noticed that I don't know what pomoplus is and what it should be doing. Adding README would be quite welcome.

@notEvil
Copy link

notEvil commented Aug 25, 2024

I tried it on Bjs1 using the emulator and looks good to me, with const SCALING = W/g.getWidth().

@thyttan thyttan marked this pull request as ready for review August 25, 2024 15:30
@thyttan
Copy link
Collaborator Author

thyttan commented Aug 25, 2024

I tried it on Bjs1 using the emulator and looks good to me, with const SCALING = W/g.getWidth().

That will undo the scaling though - it will always evaluate to 1 and not do anything. Did it not look good with = W/176?

Also reword the comment regarding SCALING.
@notEvil
Copy link

notEvil commented Aug 27, 2024

True, silly me. Didn't know what its supposed to look like and preferred a little more spacing between things. But thats just a matter of taste, don't feel obliged to change, especially because I'm bad at visual design in general :)

@thyttan
Copy link
Collaborator Author

thyttan commented Aug 27, 2024

@notEvil

and preferred a little more spacing between things. But thats just

With that in mind I made it so widgets and buttons hide when the watch is locked - what do you think? It may not be a direct response to your sentiment but maybe it at least looks a little less 'cluttered' and more 'spacey' when one is not interacting with the app?

@thyttan
Copy link
Collaborator Author

thyttan commented Sep 7, 2024

Thanks @pavelmachek and @notEvil for your feedback. I'll merge this now.

@thyttan thyttan merged commit 4d8c46b into espruino:master Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants