Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn - Simple Calorie Counter #3448

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Burn - Simple Calorie Counter #3448

merged 11 commits into from
Jun 9, 2024

Conversation

slynchDev
Copy link
Contributor

Fixes applied per your suggestion (prior PR)

@slynchDev
Copy link
Contributor Author

My apologies, I should have kept the prior PR and updated that branch rather than create a new PR (still learning the process here). I applied your suggestions: remove a few unused variables, removed .prettierignore, renamed all app files per the standard in the repo. Thanks

@thyttan
Copy link
Collaborator

thyttan commented Jun 9, 2024

Thank you for the app and the quick changes! Always fun to see new contributors! :)

@thyttan thyttan merged commit 21825d9 into espruino:master Jun 9, 2024
1 check passed
@slynchDev
Copy link
Contributor Author

slynchDev commented Jun 9, 2024 via email

@thyttan
Copy link
Collaborator

thyttan commented Jun 9, 2024

Thank you! I did have a couple questions if you don’t mind?

Sure - I'll answer to the best of my abilities. :)

  1. I see there a centralized health service to store calories information
    like this?

There's the health app that log some stats, https://thyttan.github.io/BangleApps/?q=health, is that what you're referencing? @gfwilliams has proposed to add more stats to health here: #3275 (comment)

  1. Any chance you could elaborate on your boot.js feature request
    (calculate on startup)?

The suggestion was based of my misunderstanding of the app. I thought the idea was that it would automatically estimate calories burned based on activity. If that had been the case it would have made sense to have logic running at all times, also when other apps/the clock was running, to keep track on the activity/calorie burn. But as I understand it the idea is you use the app to count caloric intake?

@slynchDev
Copy link
Contributor Author

slynchDev commented Jun 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants