Recorder: 1 second period with 1 decimal place

[thyttan]

This will make logs with 1 second periods record time with 1 decimal place precision.

EDIT3 - my first solution seemed to behave weirdly to me. But after sitting on it I realized it was probably just floating point number math doing what it does. The discussion that followed here no longer applies.

[thyttan]

So I guess it was just floating point math doing its thing, and not wrong per se. To get nicer formatting in the csv file, I've converted to string.

Seems to give good results now.

[bobrippling]

Yeah that's floating point - there's no way to represent some numbers with that level of precision, and the nearest representable number might not be displayable in decimal (like how we can't write 1/3 in decimal)

So:

Math.round(n * 10) / 10

won't necessarily give you a number with a single decimal place. If you want that, you could try n.toFixed(1), which will give you exactly 1 decimal place (in a string), for popping into the CSV if you prefer

[thyttan]

I tested the current code by recording just the time and battery status with periods 1 second and 2 seconds for ca 10 seconds each. Seems to work as it should.

EDIT: Also tried downloading the track with the recorder interface on the app loader and that also worked.

Thanks for the tips @bobrippling and for the feedback on #2819 @gfwilliams!

[bobrippling]

Nice - those changes LGTM, shall see if Gordon has anything to mention though 👀

[bobrippling]

I think let's merge - we can pick up other parts in #2819 if needed