Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot, setting: whitelist: try to resolve peer address #2973

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ssievert42
Copy link
Contributor

This uses NRF.resolveAddress() on newer firmwares, to try to resolve "random private resolvable addresses" of peers that connect, before checking the whitelist.

Now we can finally whitelist smartphones that change their address :)

@ssievert42 ssievert42 marked this pull request as draft August 16, 2023 07:07
@ssievert42 ssievert42 marked this pull request as ready for review August 16, 2023 07:12
This uses NRF.resolveAddress() on newer firmwares, to try to resolve "random private resolvable addresses" of peers that connect, before checking the whitelist.
@gfwilliams
Copy link
Member

Thanks! Just wondering, do we really need the (resolved) bit? Do the whitelisted addresses render ok in the menu with that extra length? It looks a bit like we only use the first 17 chars so it might be ok, but if that's the case, is there much point adding (resolved) to them anyway?

@ssievert42
Copy link
Contributor Author

The addresses still render ok in both the whitelist menu (where everything aside from the first 17 chars is omitted anyways) and the menu where an address can be removed, where it just wraps to the next line, but still nicely fits on the screen, with a bunch of free space above and below 👍

I wanted to have an indicator that an address was resolved, and to limit the resolving stuff to only cause a match in the whitelist if the device was added using its resolvable address.

So the (resolved) part at the end is not really needed, but I'd like having it there :)

@gfwilliams
Copy link
Member

Ok, no worries - thanks for the explanation!

@gfwilliams gfwilliams merged commit 720d34b into espruino:master Aug 16, 2023
1 check passed
@ssievert42 ssievert42 deleted the whitelist_address_resolve branch August 26, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants