feat: xflow integration #1597
Open
feat: xflow integration #1597
+5,033
−429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/espressocash_app/pubspec.lock # packages/espressocash_app/pubspec.yaml
|
@Merculiar please resolve conflicts |
# Conflicts: # packages/espressocash_app/lib/features/ramp/screens/ramp_amount_screen.dart # packages/espressocash_app/lib/l10n/intl_en.arb
|
@ookami-kb resolved |
ookami-kb
requested changes
Nov 12, 2024
| @@ -71,12 +76,11 @@ dependencies: | |||
| shared_preferences: ^2.2.2 | |||
| sliver_tools: ^0.2.12 | |||
| smooth_page_indicator: ^1.1.0 | |||
| solana: | |||
| path: ../solana/ | |||
| solana: ^0.31.0 | |||
There was a problem hiding this comment.
"Request" text doesn't fit now, it shouldn't be the case.
|
|
||
| await fetchUserData(); | ||
|
|
||
| // TODO(vsumin): Currently do not work on test environment |
There was a problem hiding this comment.
It should be working now, just doesn't send the code.
| }, | ||
| ); | ||
|
|
||
| await _kycUserClient.init(walletAddress: _ecWallet.publicKey.toString()); |
There was a problem hiding this comment.
This will initialize in background, and if it fails, client will stay in the broken state.
| return true; | ||
| } on Exception { | ||
| if (!mounted) return false; | ||
| showCpErrorSnackbar( |
There was a problem hiding this comment.
It's not necessarily wrong code, what if it's network exception?
There was a problem hiding this comment.
Updated error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Xflow integration:
Checklist