Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: portfolio amount value #1504

Merged
merged 6 commits into from
Jul 7, 2024
Merged

fix: portfolio amount value #1504

merged 6 commits into from
Jul 7, 2024

Conversation

Jaxiii
Copy link
Contributor

@Jaxiii Jaxiii commented Jun 23, 2024

Changes

Replaces '<$0.01' to '-' when value is unknown

Related issues

Fixes #1503

Screenshots & Videos

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-23 at 14 51 37

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-24 at 14 18 51

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-25.at.13.45.50.mp4

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@Jaxiii Jaxiii linked an issue Jun 23, 2024 that may be closed by this pull request
@Jaxiii Jaxiii marked this pull request as ready for review June 23, 2024 18:13
@Jaxiii Jaxiii requested a review from ookami-kb as a code owner June 23, 2024 18:13
@romeo4934
Copy link
Collaborator

@Jaxiii Please remove the total value to $0.00 of crypto portofolio if token price are not available

@Jaxiii Jaxiii requested a review from romeo4934 June 24, 2024 09:01
@Jaxiii Jaxiii requested a review from ookami-kb July 1, 2024 08:16
@ookami-kb ookami-kb merged commit 882ec27 into master Jul 7, 2024
8 checks passed
@ookami-kb ookami-kb deleted the fix/portfolio-zero-values branch July 7, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when we don't have network connection, don't display <$0.1
3 participants