Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Small fixes #528

wants to merge 1 commit into from

Conversation

Misiu
Copy link
Contributor

@Misiu Misiu commented Sep 8, 2023

While browsing the code in VS I noticed some small places that showed errors when I removed ignoreDeprecations in tsconfig.

I've added the missing semicolon in src/devices/configured-device-card.ts and also adjusted the type property in src/components/process-dialog.ts and src/components/remote-process.ts
There was a missing cast in src/wizard/wizard-dialog.ts, so I've also added it.

replace undefined with one
missing semicolon
adjust type property
@@ -267,7 +267,7 @@ class ESPHomeInstallChooseDialog extends LitElement {
<mwc-circular-progress
active
?indeterminate=${progress === undefined}
.progress=${progress !== undefined ? progress / 100 : undefined}
.progress=${progress !== undefined ? progress / 100 : 1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using the ifDefined helper from lit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried adding ifDefined, but I get this error then:
image

not sure if this is a false-positive, but lit-plugin shows me many errors, including Type 'true' is not assignable to 'string' for empty scrimClickAction, ref: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants