Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert event wait functions back to immutable #380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert event wait functions back to immutable #380

wants to merge 2 commits into from

Conversation

torkleyy
Copy link
Contributor

@torkleyy torkleyy commented Mar 5, 2024

Also adds the new mutable versions as _mut

ivmarkov
ivmarkov requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@ivmarkov ivmarkov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the _mut methods. I'm not sure they give that much of a value other than the fact that the user code that waits can also modify the state of the driver while waiting. But why should it do that...?

@torkleyy
Copy link
Contributor Author

torkleyy commented Mar 5, 2024

I don't know why, but the functions were changed so I assumed that somebody needed that functionality...

@ivmarkov
Copy link
Collaborator

@torkleyy Sorry for the delay in replying here: the examples don't really build after that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivmarkov ivmarkov ivmarkov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torkleyy @ivmarkov