Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for ethernet #289

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Add example for ethernet #289

merged 4 commits into from
Aug 31, 2023

Conversation

torkleyy
Copy link
Contributor

No description provided.

@torkleyy
Copy link
Contributor Author

Just noticed that most of the examples are missing link_patches, should we add it?

@ivmarkov
Copy link
Collaborator

Number and type of GPIOs are MCU-specific.
You need to #[cfg(esp32)], #[cfg(esp32c3)] and so on. Or you can only do a single #[cfg(esp32)] and for the other MCUs panic with an error that the user needs to adjust the GPIOs for their MCUs in the example and then run it.

examples/eth.rs Outdated Show resolved Hide resolved
examples/eth.rs Outdated
@@ -0,0 +1,65 @@
use esp_idf_sys::{self as _}; // If using the `binstart` feature of `esp-idf-sys`, always keep this module imported
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary - remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing this it's giving me linker errors.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. How about use esp_idf_svc::sys::{self as _};? If same story, I'll need to see what is going on...

examples/eth.rs Show resolved Hide resolved
@ivmarkov ivmarkov merged commit 95ba24b into esp-rs:master Aug 31, 2023
8 checks passed
@torkleyy torkleyy deleted the eth branch August 31, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants