feat: wifi power-save mode #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivmarkov
requested changes
Oct 31, 2021
| @@ -828,7 +851,7 @@ impl Drop for EspWifi { | |||
| fn drop(&mut self) { | |||
| unsafe { | |||
| TAKEN.lock(|taken| { | |||
| self.clear_all().unwrap(); | |||
| // self.clear_all().unwrap(); | |||
There was a problem hiding this comment.
Forgotten debugging code?
There was a problem hiding this comment.
most likely, I think I ran into a crash related to this, but I don't remember for sure
| @@ -301,6 +320,10 @@ impl EspWifi { | |||
| Ok(wifi) | |||
| } | |||
|
|
|||
| pub fn set_power_save_mode(&mut self, mode: PowerSaveMode) -> Result<(), EspError> { | |||
There was a problem hiding this comment.
Just for symmetry, perhaps implement also get_power_safe_mode?
ivmarkov
force-pushed
the
master
branch
3 times, most recently
from
8a8adba
to
5ccb542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.