-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PSRAM in DmaTxBuf #2161
base: main
Are you sure you want to change the base?
Conversation
bfab3ce
to
a6f8bbd
Compare
Lovely, maybe it has something to do with the reduced bandwidth of QSPI vs OSPI? |
Actually I think it was because one of my modules only has quad psram-2m and I had it configured for opsram-2m example seems to work now |
201a9c8
to
62f4d89
Compare
0c8700d
to
e0600ae
Compare
e0600ae
to
374a334
Compare
add `dma_tx_buffer` macro
…ed - its not needed for dram anyway.
fe8ef3a
to
68f076a
Compare
// no need for block size if the buffer is in DRAM | ||
if is_slice_in_dram(buf.buffer) { | ||
buf.block_size = None; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a check here to make sure block_size is provided when the buffer is in PSRAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested dma from psram with all of the block sizes and they all worked on octal psram. I think even none worked - that would have used the default register value. But yea - maybe we should force users to be specific.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packages
command to ensure that all changed code is formatted correctly.CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR adds support for PSRAM in DmaTxBuf allowing DMA transfers out from PSRAM.
Some observations:
Testing
-The example now works with log (actual issue was my confusion)
opsram-8m
and one withpsram-2m