Cdata sections #59
Open
Cdata sections #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when printing to binary, exml has an enforced way to implement escaping, that is, by escaping character by character, which, in the case of many characters that need escaping, increases the binary size dramatically, and also makes the binary less readable to the debugging eye. So we need a mechanism to tell exml to use cdata when desired.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 71.49% 73.32% +1.83%
==========================================
Files 7 7
Lines 1098 1106 +8
Branches 158 160 +2
==========================================
+ Hits 785 811 +26
+ Misses 313 295 -18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that some subelement can contain a payload with for example, a big json object. The xml element could be use as an envelope for routing other abstract payloads, and so escaping them could make the blob much bigger for the network transfer, and very unreadable for the debugging eye. So at least make it optional that you want to use cdata escaping when needed.
There's also a couple of "breaking" changes, current code was doing
iolist_to_binaryfor the function calledto_iolist, which seems dummy, you might as well callto_binaryif you want a binary. iodata usually has a performance advantage improvement for network transmission, so keep iodata as iodata when you want it.