Allow JIDs from all MUC light domains in HTTP room API #1622
Conversation
fenek
force-pushed
the
http-room-api-allow-jids-from-var-domains
branch
from
f771724
to
7b0267d
Compare
src/mongoose_client_api_rooms.erl
Outdated
|
|
||
| -spec validate_room_host(binary()) -> ok | error. | ||
| validate_room_host(RoomHost) -> | ||
| MucLightDomains = ejabberd_router:dirty_get_routes_to_module(mod_muc_light), |
There was a problem hiding this comment.
Feels a bit hackish. Instead of adding this API, can we reuse mongoose_subhosts:get_host/1?
There was a problem hiding this comment.
Still, we're not sure if that subhost is a MUC light domain. IMO router is a more appropriate place to look for that information, because it is exactly the place where that information is registered (I mean the host <-> module mapping).
src/mongoose_client_api_rooms.erl
Outdated
| -spec validate_room_host(binary()) -> ok | error. | ||
| validate_room_host(RoomHost) -> | ||
| MucLightDomains = ejabberd_router:dirty_get_routes_to_module(mod_muc_light), | ||
| case lists:member(RoomHost, MucLightDomains) of |
There was a problem hiding this comment.
this would not work well in case of a lot of domains.
There was a problem hiding this comment.
I agree, I need to come up with better solution.
Log message:
Lager fatally failed to install handler lager_console_backend into
lager_event, NOT retrying: {bad_console_config, info}
Fix broken lager_console_backend backend
|
@arcusfelis @fenek in hope to address concerns of both of you, I propose to replace |
|
@arkgil dirty_check_route_exists/2 makes sense. |
|
OK, sounds good. :) Also I think that |
arkgil
force-pushed
the
http-room-api-allow-jids-from-var-domains
branch
from
7b0267d
to
1d40acd
Compare
|
@fenek @arcusfelis I've added negative test cases and one test to ensure that rooms can be actually created at different domain. However I noticed that if we'd like to fully support running multiple MUC light services on a single host, couple of changes would need to be made, e.g.:
|
This comment was marked as spam.
This comment was marked as spam.
This PR allows passing room JID from all configured MUC light domains in HTTP room API routes. Previously the JID needed to be in a "primary" MUC light domain on host (started via
mod_muc_light:start/2). If only username part of JID is given, still "primary" domain is assumed.