Add possibility enable emit unpopulated and default values. #6
Conversation
…eature/add-emit-unpopulated-and-default-values
pkg/transport/transport.go
Outdated
| w.WriteHeader(http.StatusInternalServerError) | ||
| } | ||
|
|
||
| fmt.Fprint(w, response) |
There was a problem hiding this comment.
Avoid using of fmt when writing HTTP response body. Use io.Copy, io.WriteString() or w.Write().
| response, err := rc.Encoder.Format(rpcResponse) | ||
| if err != nil { | ||
| logger.ErrorContext(r.Context(), jErrors.Details(jErrors.Trace(err))) | ||
| w.WriteHeader(http.StatusInternalServerError) |
README.md
Outdated
| @@ -40,6 +40,8 @@ Usage of ./grpc-rest-proxy: | |||
| --transport.http.server.gracefulTimeout duration graceful timeout (default 5s) | |||
| --transport.http.server.readHeaderTimeout duration read header timeout (default 5s) | |||
| --transport.http.server.readTimeout duration read timeout (default 10s) | |||
| --service.jsonencoder.emitUnpopulated emit unpopulated fields | |||
There was a problem hiding this comment.
Add more detailed description for new cli flags. Imagine user who is using this cli app for the first time.
pkg/service/jsonencoder/encoder.go
Outdated
| opts protojson.MarshalOptions | ||
| } | ||
|
|
||
| func NewOptions(cfg *Config) Encoder { |
There was a problem hiding this comment.
Rename NewOptions() to New().
Compare
encoder := jsonencoder.NewOptions(cfg)vs
encoder := jsonencoder.New(cfg)
pkg/service/jsonencoder/encoder.go
Outdated
| } | ||
| } | ||
|
|
||
| func (e Encoder) Format(m proto.Message) (string, error) { |
There was a problem hiding this comment.
Optional: Change return value to ([]byte, error). This way returned value of []byte can be used to write HTTP response body in w.Write() without need to convert []byte to string and then back to []byte.
There was a problem hiding this comment.
Optional: Rename from Format to Encode. The name of struct is Encoder. Encoder is used for encoding. Formatter is used for formatting.
Compare
jsonResponse, err := jsonEncoder.Format(protoResponse)with
jsonResponse, err := jsonEncoder.Encode(protoResponse)
No description provided.