Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Write os-var replaced .src file to temp file, and rename #938

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Write os-var replaced .src file to temp file, and rename #938

wants to merge 2 commits into from

Commits on May 23, 2024

  1. fix: Write os-var replaced .src file to temp file, and rename 

    The replace_os_vars function is called for any command, not only those that boot the release. If you invoke <release> status in a readiness check, that will write the file again.

This might lead to race conditions, where the release starts up, but the health check will re-render the sys.config and write it halfway while the boot gets around to read it.
    @chsukivra
    chsukivra authored May 23, 2024
    Configuration menu
    Copy the full SHA
    1a8f4e0 View commit details
    Browse the repository at this point in the history

  2. fix: use pattern with 6 X, busybox mktemp (alpine) requires it

    @chsukivra
    chsukivra authored May 23, 2024
    Configuration menu
    Copy the full SHA
    be1fd37 View commit details
    Browse the repository at this point in the history