Removed unicode_str & fun_stacktrace #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Mar 5, 2024
src/ec_date.erl
Outdated
| @@ -709,11 +709,7 @@ pad6(X) when is_integer(X) -> | |||
| ltoi(X) -> | |||
| list_to_integer(X). | |||
|
|
|||
| -ifdef(unicode_str). | |||
| uppercase(Str) -> string:uppercase(Str). | |||
There was a problem hiding this comment.
should we just keep the intermediary call here or also fold in the uppercase/1 call to be string:uppercase/1?
There was a problem hiding this comment.
Folded all down to string:uppercase/1: no blocker.
src/ec_git_vsn.erl
Outdated
| @@ -99,16 +99,10 @@ parse_tags(Pattern) -> | |||
| {Tag, Vsn1} | |||
| end. | |||
|
|
|||
| -ifdef(unicode_str). | |||
| len(Str) -> string:length(Str). | |||
| trim(Str, right, Chars) -> string:trim(Str, trailing, Chars); | |||
| trim(Str, left, Chars) -> string:trim(Str, leading, Chars). | |||
There was a problem hiding this comment.
same question here. Can we or should we remove these intermediary calls? Any blockers?
src/ec_talk.erl
Outdated
| @@ -197,13 +197,8 @@ get_string(String) -> | |||
| no_clue | |||
| end. | |||
|
|
|||
| -ifdef(unicode_str). | |||
| trim(Str) -> string:trim(Str). | |||
| trim(Str, both, Chars) -> string:trim(Str, both, Chars). | |||
| @@ -886,7 +871,6 @@ runmany_wrap(Fun, Parent) -> | |||
| throw:R:Stacktrace -> | |||
| Parent ! {erlang:self(), error, {{nocatch, R}, Stacktrace}} | |||
| end. | |||
There was a problem hiding this comment.
This one definitely needs to stay around.
ariel-anieli
force-pushed
the
pr-stacktrace
branch
from
dc9a836
to
f878e9f
Compare
|
Rebasing the PR; one extra commit has gone thru. |
added 2 commits
March 7, 2024 06:58
* introduced in ad2d57d * CI/CD uses R23 and onwards * erlang:get_stacktrace/0 removed in R23. [1] https://www.erlang.org/doc/general_info/removed#functions-removed-in-otp-23
* introduced in f8f72b7 * introduced for working around compile warning starting from R20 * CI/CD uses R23 and onwards.
ariel-anieli
force-pushed
the
pr-stacktrace
branch
from
f878e9f
to
f378d3e
Compare
|
Good; please go ahead. |
ferd
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode_str(introduced in f8f72b7) to work around R20 compile warningsfun_stacktrace(introduced in ad2d57d) relies onerlang:get_stacktrace/0, deprecated from R23.