Update expressions.py #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in latests python and pip version of 03.07.2024 I discovered this issue
File "..../lib/python3.12/site-packages/parsimonious/expressions.py", line 9, in <module>
from inspect import getargspec
ImportError: cannot import name 'getargspec' from 'inspect' (..../lib/python3.12/inspect.py). Did you mean: 'getargs'?
tested it on both linux and windows
lucaswiman
reviewed
Jul 2, 2024
There was a problem hiding this comment.
inspect.getargs doesn't seem to be documented and also doesn't work here. (It expects code objects, not callables.)
getfullargspect does exist in 3.12. The issue is that the version currently in pypi is old. I think releasing the current version to pypi is the right approach.
|
Actually, @RaduGeorgescu Are you sure you're on the latest version of Parsimonious (0.10.0)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in latests python and pip version of 03.07.2024 I discovered this issue
File "..../lib/python3.12/site-packages/parsimonious/expressions.py", line 9, in
from inspect import getargspec
ImportError: cannot import name 'getargspec' from 'inspect' (..../lib/python3.12/inspect.py). Did you mean: 'getargs'?
Replicated the error on both linux and windows environments. not sure if what I did fixed the problem, but for me it did the job