-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-12: Encode/decode box value and token amount from JSON as either a number or a string #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1311666546
💛 - Coveralls |
greenhat
changed the title
Encode/decode box value and token amount from JSON as either a number or a string
EIP-12: Encode/decode box value and token amount from JSON as either a number or a string
Jul 21, 2021
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
from
July 29, 2021 13:21
f23bc09
to
82a121e
Compare
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
from
July 29, 2021 16:26
82a121e
to
82404ab
Compare
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
from
August 22, 2021 06:32
39e0830
to
804108e
Compare
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
from
September 13, 2021 11:47
05ed5a7
to
6247283
Compare
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
2 times, most recently
from
October 6, 2021 10:57
dfa8cdd
to
7248702
Compare
add `serde_with` crate;
to return String instead of JsValue (to avoid silent accuracy loss on JSON->Text on JS side);
ditch rand impl in `sigma_protocol::crypto_utils` in favor of k256 bundled rand_core;
add `to_json_dapp` for `ErgoBox` and `Token`;
add ErgoBox.to_json_dapp() test in JS;
to handle convert from TxIoVec types;
greenhat
force-pushed
the
i345-box-value-token-as-string
branch
from
October 6, 2021 11:28
7248702
to
8674eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #345
EIP-12
to_json_dapp()
inTransaction
andUnsignedTransaction
in Wasm that encode box value and token amount as string;Transaction::to_json_dapp()
;UnsignedTransaction::to_json_dapp()
;BoxValue
as string;TokenAmount
as string;to_json_dapp()
in all types that haveto_json()
to_json()
in ALL types to return text (avoid silent accuracy loss on JS object -> text on JS side);