Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom deploy addon support cluster addon and can select version #6446

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

feat custom deploy addon support cluster addon and can select version

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English feat custom deploy addon support cluster addon and can select version
🇨🇳 中文 自定义部署Addon支持集群级别Addon并且支持版本选择

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 42.37288% with 68 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (9aaa584) to head (b828159).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/tools/orchestrator/services/addon/addon.go 0.00% 41 Missing ⚠️
...tools/orchestrator/services/addon/addon_handler.go 54.54% 20 Missing ⚠️
...chestrator/services/addon/addon_extension_cache.go 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6446      +/-   ##
==========================================
+ Coverage   15.14%   15.16%   +0.02%     
==========================================
  Files        3674     3674              
  Lines      376844   376905      +61     
==========================================
+ Hits        57076    57163      +87     
+ Misses     314307   314280      -27     
- Partials     5461     5462       +1     
Flag Coverage Δ
by-github-actions 15.16% <42.37%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/tools/orchestrator/endpoints/addon.go 6.73% <100.00%> (+3.70%) ⬆️
internal/tools/orchestrator/endpoints/endpoints.go 6.53% <100.00%> (+6.53%) ⬆️
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% <ø> (ø)
...chestrator/services/addon/addon_extension_cache.go 67.18% <0.00%> (-8.26%) ⬇️
...tools/orchestrator/services/addon/addon_handler.go 31.79% <54.54%> (-0.16%) ⬇️
...nternal/tools/orchestrator/services/addon/addon.go 13.56% <0.00%> (-0.09%) ⬇️

... and 13 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/tools/orchestrator/services/addon/addon.go Outdated Show resolved Hide resolved
internal/tools/orchestrator/endpoints/addon.go Outdated Show resolved Hide resolved
@CeerDecy CeerDecy requested a review from iutx October 24, 2024 07:15
iutx
iutx previously approved these changes Oct 28, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

apistructs/addon.go Show resolved Hide resolved
apistructs.AddonMSENacos, // mse-nacos only can be deployed by `config-center` or `register-center`
}
createableAddonVersion := map[string]string{
apistructs.AddonApiGateway: "3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these default addon:version pairs should be putted in envs or db configs, for easier modifying.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, I found these version just for getting AddonSpec, now I've changed it to get AddonSpec from cache.

@sfwn
Copy link
Member

sfwn commented Nov 1, 2024

/approve

@erda-bot erda-bot merged commit 2270271 into erda-project:master Nov 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants