Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: get phase using string name #932

Closed
wants to merge 4 commits into from

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil force-pushed the refact_getPhase branch 2 times, most recently from 3b88c73 to 7bffe6c Compare February 27, 2024 14:11
@asmfstatoil asmfstatoil marked this pull request as draft February 27, 2024 14:12
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.21622% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 34.69%. Comparing base (388d877) to head (ba49e1c).

Files Patch % Lines
...processSimulation/util/monitor/StreamResponse.java 0.00% 20 Missing ⚠️
.../main/java/neqsim/thermo/util/empiric/DuanSun.java 0.00% 2 Missing ⚠️
...va/neqsim/PVTsimulation/simulation/DensitySim.java 0.00% 1 Missing ⚠️
.../neqsim/PVTsimulation/simulation/ViscositySim.java 0.00% 1 Missing ⚠️
...m/PVTsimulation/simulation/ViscosityWaxOilSim.java 0.00% 1 Missing ⚠️
...eNode/twoPhasePipeFlowNode/StratifiedFlowNode.java 0.00% 1 Missing ⚠️
...sSimulation/measurementDevice/MultiPhaseMeter.java 50.00% 1 Missing ⚠️
...on/processEquipment/reservoir/SimpleReservoir.java 0.00% 1 Missing ⚠️
...mulation/processEquipment/separator/Separator.java 0.00% 1 Missing ⚠️
...Simulation/processEquipment/subsea/SubseaWell.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #932      +/-   ##
============================================
- Coverage     34.69%   34.69%   -0.01%     
  Complexity     5274     5274              
============================================
  Files           700      700              
  Lines         69741    69741              
  Branches       7984     7984              
============================================
- Hits          24196    24195       -1     
- Misses        44063    44064       +1     
  Partials       1482     1482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil deleted the refact_getPhase branch March 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants