Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: use PhaseType enum #929

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

asmfstatoil
Copy link
Collaborator

do not use integer types to refer to phase type.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.76650% with 162 lines in your changes are missing coverage. Please review.

Project coverage is 33.63%. Comparing base (032c89c) to head (63a20b1).

Files Patch % Lines
src/main/java/neqsim/thermo/phase/PhaseUMRCPA.java 0.00% 21 Missing ⚠️
.../java/neqsim/thermo/phase/PhaseElectrolyteCPA.java 28.57% 13 Missing and 2 partials ⚠️
src/main/java/neqsim/thermo/phase/PhaseSrkCPA.java 38.09% 11 Missing and 2 partials ⚠️
...m/thermo/phase/PhaseSrkCPA_proceduralMatrices.java 0.00% 13 Missing ⚠️
...in/java/neqsim/thermo/phase/PhaseSrkCPAojAlgo.java 0.00% 13 Missing ⚠️
...va/neqsim/thermo/phase/PhaseElectrolyteCPAOld.java 0.00% 8 Missing ⚠️
.../main/java/neqsim/thermo/phase/PhaseCSPsrkEos.java 0.00% 7 Missing ⚠️
...ava/neqsim/thermo/component/ComponentGEUnifac.java 0.00% 6 Missing ⚠️
...va/neqsim/thermo/component/ComponentGEUniquac.java 0.00% 6 Missing ⚠️
...ation/processEquipment/mixer/StaticPhaseMixer.java 0.00% 5 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #929   +/-   ##
=========================================
  Coverage     33.63%   33.63%           
  Complexity     5125     5125           
=========================================
  Files           699      699           
  Lines         69791    69779   -12     
  Branches       7991     7991           
=========================================
- Hits          23474    23472    -2     
+ Misses        44841    44831   -10     
  Partials       1476     1476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement for readability of code.

@asmfstatoil asmfstatoil merged commit f3a2a7c into equinor:master Feb 26, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the refact_int_phasetype branch February 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants