Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor error in test #918

Closed
wants to merge 9 commits into from
Closed

Fix minor error in test #918

wants to merge 9 commits into from

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Feb 16, 2024

No description provided.

Sviatose and others added 9 commits February 16, 2024 16:33
Bug had to do when we create a stream from another stream (as we do for stream2). Then we set temperature and pressure on it - but it does not set it on the correct stream
* bug: MPM returns incorrect value

* bug fix suggestion.

Bug had to do when we create a stream from another stream (as we do for stream2). Then we set temperature and pressure on it - but it does not set it on the correct stream

* added init properties

* bug fix

* update

* fix bug

* new fix

---------

Co-authored-by: Sviatoslav Eroshkin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (449219b) 33.59% compared to head (f60a3ff) 33.62%.
Report is 1 commits behind head on master.

❗ Current head f60a3ff differs from pull request most recent head 7f98867. Consider uploading reports for the commit 7f98867 to get more accurate results

Files Patch % Lines
...cessSimulation/processEquipment/stream/Stream.java 57.14% 18 Missing ⚠️
...sSimulation/measurementDevice/MultiPhaseMeter.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #918      +/-   ##
============================================
+ Coverage     33.59%   33.62%   +0.02%     
- Complexity     5123     5127       +4     
============================================
  Files           701      701              
  Lines         69794    69814      +20     
  Branches       7989     7991       +2     
============================================
+ Hits          23450    23473      +23     
+ Misses        44868    44865       -3     
  Partials       1476     1476              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants