Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option to run isothermally pipe Beggs and Brills #779

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

Sviatose
Copy link
Collaborator

  1. Made the variables private to ensure that their internal state is not directly accessible or modifiable by other classes.
  2. Added option to run isothermally
  3. Added more get methods (angle, elevation)
  4. fix: return total length instead of segment length

@Sviatose Sviatose requested a review from EvenSol as a code owner July 17, 2023 13:06
@EvenSol
Copy link
Collaborator

EvenSol commented Jul 20, 2023

I see the test of beggs and brills fail with a null pointer exception. I can look into that later. Any idea why it happens ? @Sviatose

@Sviatose
Copy link
Collaborator Author

Hm, does not fail when I run test locally, but it was a problem with PH flash

@EvenSol EvenSol merged commit f6ac3ab into master Jul 22, 2023
2 checks passed
@EvenSol EvenSol deleted the feat--isothermalCalcEnabledPipeBandB branch July 22, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants