Support building for py310 and on rhel8 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwinkunks
reviewed
Jan 18, 2023
There was a problem hiding this comment.
These explicit checks should probably not be in the FOSS code. It feels weird to have business rules hardcoded into the linter --- especially such Equinor-centric rules.
Haven't given it tons of thought, but maybe best would be to have a config that specifies some default regexes which can be overridden. But this is probably overkill for now. Not sure what a 'light touch' solution that meets our needs would look like.
Not urgent so this can turn into an issue, by all means. I know there are several other things that need to be generalized like this.
|
Made #313 to deal with the de-Equinorization later. |
kwinkunks
reviewed
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.