Implement stop button #140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andchiind
force-pushed
the
implement-stop
branch
from
1c35c18
to
b4e75c5
Compare
andchiind
force-pushed
the
implement-stop
branch
from
b4e75c5
to
9ed419c
Compare
andchiind
force-pushed
the
implement-stop
branch
from
9ed419c
to
a135c03
Compare
Christdej
reviewed
Mar 5, 2024
| ) | ||
| max_request_attempts: int = 10 | ||
| stop_mission_attempts: int = 0 | ||
| while stop_mission_attempts < max_request_attempts: |
There was a problem hiding this comment.
Maybe a comment on why we need to try stopping so many times?
There was a problem hiding this comment.
I think I'll test soon without these retries and see how reliable it is now that we have more error handling. We might not need the retries.
|
This pull request has automatically been marked as stale as there has been no activity for 30 days. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121