Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reindent code / merge features of MCS driver that were lost since from version 1.5.0 #23

Closed
wants to merge 2 commits into from

Conversation

ganymede42
Copy link

The pull request consists of 2 commits:

  1. reindent anf formating code -> code consistency has been checkt with bcompare

  2. many changes on MCS to support rotary encoder and to set the positioner type
    further this commit contains also many improvements of the MCS2 code

  3. reindent, delete trailling spaces, remove unused variables

  4. MCS: merge lost features from 1.5.1, MCS2: various

    • merge features of MCS driver that were lost since from version 1.5.0
      • Add PTYPE, MCF, AUTO_ZERO, CAL option
      • Fix jog for rot stages
    • support PTYPE, MCF and other MCS/MCS2 specific functionalities
    • MCS2: fix polling when there are missing positioner
    • MCS2: support positioners without encoder
    • simplify debugging with DBG_PRINTF

Thierry Zamofing added 2 commits September 12, 2023 10:44
- merge features of MCS driver that were lost since from version 1.5.0
  - Add PTYPE, MCF, AUTO_ZERO, CAL option
  - Fix jog for rot stages
- support PTYPE, MCF and other MCS/MCS2 specific functionalities
- MCS2: fix polling when there are missing positioner
- MCS2: support positioners without encoder
- simplify debugging with DBG_PRINTF
@kmpeters
Copy link
Contributor

I can't merge this pull request; Commit bbccfdf removes improvements that were added in #7.

Also, are the references to versions 1.5.0 and 1.5.1 typos? I only see versions 1.2.0 and 1.2.1.

@ganymede42
Copy link
Author

Version 1.5.1 were improvments that have been done by Zan at PSI... sorry not part of the official repo.
I will try to make smaller steps, first with the cleanup of the code

@ganymede42 ganymede42 closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants