Implement missing widgets #83

evalott100 · 2024-01-25T15:01:35Z

Closes #82 and #74

... as well as adding widgets

evalott100 · 2024-01-25T15:02:28Z

The byte array stays at a constant height of 20 and has a width of 20 times by the number of bits

codecov-commenter · 2024-01-26T14:09:12Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b2f67a3) 89.19% compared to head (76862ea) 89.23%.

Files	Patch %	Lines
src/pvi/_format/widget.py	87.50%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   89.19%   89.23%   +0.03%     
==========================================
  Files          23       23              
  Lines        1379     1393      +14     
==========================================
+ Hits         1230     1243      +13     
- Misses        149      150       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

evalott100 · 2024-01-29T15:41:07Z

Images can now be added. Progress bar now has options for maximum and minimum, which will be ignored if a new field use_machine_limits is true.

evalott100 · 2024-02-05T11:05:33Z

Progress bar, CheckBox is now actually a checkbox widget.

evalott100 · 2024-02-05T14:13:48Z

I put the CheckBox widget back to how it was since #81 will change them anyway.

Also added a plot, the x axis is left blank, with a waveform phoebus just uses an x-axis of indices.

schemas/pvi.device.schema.json

src/pvi/_format/dls.bob

src/pvi/_format/dls.py

tests/format/output/button.bob

GDYendell · 2024-02-19T14:34:22Z

Could you squash the last 3 commits into the previous ones as they appear to just be reverting things. Also happy to just squash everything except the first commit into one.

src/pvi/_format/bob.py

src/pvi/_format/adl.py

evalott100 · 2024-02-20T14:08:47Z

@GDYendell I'll make a new issue for splitting mixedWidgets up.

#98

Added a byte monitor widget image widget progress bar widget array-trace widget

GDYendell

Did a bit of tidying and pulled the SignalRW fix into a separate commit. I think this is good to do.

evalott100 self-assigned this Jan 25, 2024

evalott100 marked this pull request as draft January 25, 2024 15:01

evalott100 force-pushed the implement_missing_widgets branch from a2223af to 7791df5 Compare January 26, 2024 14:07

evalott100 force-pushed the implement_missing_widgets branch from 66496db to 349a304 Compare January 29, 2024 15:38

evalott100 force-pushed the implement_missing_widgets branch 3 times, most recently from aa76266 to 11d6306 Compare January 30, 2024 08:58

evalott100 marked this pull request as ready for review February 5, 2024 14:16

evalott100 requested a review from GDYendell February 5, 2024 14:16

evalott100 force-pushed the implement_missing_widgets branch 2 times, most recently from 40100a7 to 79bb0ba Compare February 19, 2024 12:00