Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace APISchema with Pydantic2 #85

Merged
merged 30 commits into from
Aug 31, 2023
Merged

Replace APISchema with Pydantic2 #85

merged 30 commits into from
Aug 31, 2023

Conversation

gilesknap
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #85 (dd3c950) into main (8f2aace) will decrease coverage by 0.49%.
The diff coverage is 98.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   97.73%   97.24%   -0.49%     
==========================================
  Files           9        9              
  Lines         397      363      -34     
==========================================
- Hits          388      353      -35     
- Misses          9       10       +1     
Impacted Files Coverage Δ
src/ibek/modules.py 100.00% <ø> (ø)
src/ibek/ioc.py 96.00% <96.66%> (-1.76%) ⬇️
src/ibek/__main__.py 100.00% <100.00%> (ø)
src/ibek/gen_scripts.py 100.00% <100.00%> (ø)
src/ibek/globals.py 100.00% <100.00%> (ø)
src/ibek/render.py 97.72% <100.00%> (-0.03%) ⬇️
src/ibek/support.py 98.66% <100.00%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gilesknap gilesknap requested a review from coretl July 14, 2023 14:34
@gilesknap
Copy link
Member Author

@coretl I'm really happy with this. It came out beautiful after all. The schemas look very different but the sample docs in the tests are unchanged.

Only caveat is that the docs are broken and I can't work out how to fix them.

I'd appreciate you taking a look over the changes and maybe fixing the docs if you can. NOTE: the commit history is a mess and I'm intending to squash merge this.

@gilesknap
Copy link
Member Author

Fun fact.

render_with_utils was written by CoPilot, including the comments.

@gilesknap
Copy link
Member Author

@coretl sphinx is fixed and I have added a TODO to Entity.add_ibek_attributes regarding the issue with error messages for object type entities.

@gilesknap gilesknap merged commit f0dddc7 into main Aug 31, 2023
25 checks passed
@gilesknap gilesknap deleted the pydantic2 branch November 11, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants