Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #81 #84

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix for #81 #84

merged 2 commits into from
Jul 6, 2023

Conversation

gilesknap
Copy link
Member

Changes to the schema for defining the startup script as described in #81

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #84 (8f2aace) into main (41e06fb) will increase coverage by 0.35%.
The diff coverage is 97.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   97.38%   97.73%   +0.35%     
==========================================
  Files           9        9              
  Lines         382      397      +15     
==========================================
+ Hits          372      388      +16     
+ Misses         10        9       -1     
Impacted Files Coverage Δ
src/ibek/gen_scripts.py 100.00% <ø> (ø)
src/ibek/render.py 97.75% <96.15%> (+1.24%) ⬆️
src/ibek/support.py 98.95% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gilesknap gilesknap requested a review from coretl July 6, 2023 07:14
@gilesknap
Copy link
Member Author

I'm merging this in order to work on Pydantic conversion. I will come back to the very latest updates to the schema in #81 after pydantic conversion.

@gilesknap gilesknap merged commit b05d34f into main Jul 6, 2023
@gilesknap gilesknap deleted the script-schema branch November 11, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants