Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PVI integration #132

Merged
merged 9 commits into from
Nov 11, 2023
Merged

Add PVI integration #132

merged 9 commits into from
Nov 11, 2023

Commits on Nov 10, 2023

  1. Remove redundant output files from tests 

    These files were renamed in `5a1ee025 fix naming of subst files`
    @gilesknap @GDYendell
    gilesknap authored and GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    44950c8 View commit details
    Browse the repository at this point in the history

  2. fix pre-commit

    @gilesknap @GDYendell
    gilesknap authored and GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2766c62 View commit details
    Browse the repository at this point in the history

  3. move all runtime assets to /epics/runtime

    @gilesknap @GDYendell
    gilesknap authored and GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ca58618 View commit details
    Browse the repository at this point in the history

  4. Update support generate-links to symlink ibek and pvi yaml 

    Make generate_links take a specific support module to link rather
than doing glob of all directories.
    @GDYendell
    GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    eab3d82 View commit details
    Browse the repository at this point in the history

  5. Update ioc runtime generate to create pvi bobs and templates 

    Add PVI_DEFS to list of assets to be exported for runtime stage
Change use of Dict to Mapping to make mypy happy;

```
src/ibek/runtime_cmds/commands.py:158: error: Argument "args" to "Database" has incompatible type "dict[str, str]"; expected "dict[str, str | None]"  [arg-type]
src/ibek/runtime_cmds/commands.py:158: note: "Dict" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/ibek/runtime_cmds/commands.py:158: note: Consider using "Mapping" instead, which is covariant in the value type
```
    @GDYendell
    GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b80faef View commit details
    Browse the repository at this point in the history

  6. Use absolute imports to enable debugging module

    @GDYendell
    GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5f27215 View commit details
    Browse the repository at this point in the history

  7. Bump minimum python version to 3.10

    @GDYendell
    GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    663d5cf View commit details
    Browse the repository at this point in the history

  8. include _globals in ibek support generate-links

    @gilesknap @GDYendell
    gilesknap authored and GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5480797 View commit details
    Browse the repository at this point in the history

  9. Include standard ibek definitions in ioc generate-schema 

    This PR has highlighted an issue that CI needs to know where
to find the ibek support YAML - but ibek already knows

Added --ibek-defs for use in CI to generate schema without
breaking each time we move the /epics/ibek-defs folder. This
is the default.

The regenerate_samples.sh script can use --no-ibek-defs to
only include the given support yaml definitions.
    @gilesknap @GDYendell
    gilesknap authored and GDYendell committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e307124 View commit details
    Browse the repository at this point in the history