Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated method and add missing decorator #2072

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

nightosong
Copy link
Contributor

Description

Changes:

  1. method parse_obj is deprecated, use model_validate instead.
  2. remove meaningless f-string format.
  3. add missing classmethod decorator.

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the fix Bug fixes label Oct 16, 2024
@csunny
Copy link
Collaborator

csunny commented Oct 17, 2024

@nightosong Thanks for your PR, can you fix the check errors? You can refer to
https://github.com/eosphoros-ai/DB-GPT/blob/main/CONTRIBUTING.md

@csunny
Copy link
Collaborator

csunny commented Oct 17, 2024

dbgpt/agent/core/action/base.py :184:89: E501 line too long (91 > 88 characters)

@nightosong
Copy link
Contributor Author

@csunny The issue has been fixed. A recheck is needed.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 253c367 into eosphoros-ai:main Oct 18, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants