Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass in linked eos address and evm address instead of hardcode #48

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

yarkinwho
Copy link
Contributor

Resolve #46

Though we still cannot "configure" them during runtime, but at least they are not hardcoded in solidity anymore.

We can make them configurable when there's real requiremnents.

@yarkinwho yarkinwho requested a review from taokayan August 8, 2024 05:49
@taokayan
Copy link
Contributor

taokayan commented Aug 8, 2024

It seems this will break the compatibility.

@yarkinwho yarkinwho merged commit d342384 into main Aug 14, 2024
4 checks passed
@yarkinwho yarkinwho deleted the yarkin/remove_hardcode branch August 14, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some address related settings runtime config instead of hardcoding them
2 participants