Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/3.4 RC Removal #147

Closed
wants to merge 5 commits into from
Closed

Release/3.4 RC Removal #147

wants to merge 5 commits into from

Conversation

nsjames
Copy link
Member

@nsjames nsjames commented May 27, 2024

No description provided.

@ericpassmore
Copy link
Contributor

Approving, need another PR into main to update version to 3.5.0-dev.

ericpassmore
ericpassmore requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still needed? Ideally you would create a branch from release/3.4, add a commit to update the version to v3.5.0-dev, and then merge the new-branch-with-change into main. Otherwise this looks like a step back.

@nsjames nsjames closed this Jun 4, 2024
@nsjames
Copy link
Member Author

nsjames commented Jun 4, 2024

Yup that works @ericpassmore

New PR here: #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpassmore ericpassmore ericpassmore requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsjames @ericpassmore