Removed react-16.8 from allowed_failures in travis #2122
Conversation
AlokTakshak
changed the title
|
@ljharb |
.travis.yml
Outdated
| @@ -33,7 +33,7 @@ matrix: | |||
| - node_js: "lts/*" | |||
| env: REACT=16.8.3 | |||
| - node_js: "lts/*" | |||
| env: REACT=16.8 RENDERER=16.7 | |||
| env: REACT=16.8 RENDERER=16.8 | |||
There was a problem hiding this comment.
this is breaking the purpose of the test, which is to test react 16.8 with the 16.7 renderer.
| env: REACT=16.8 RENDERER=16.8 | |
| env: REACT=16.8 RENDERER=16.7 |
There was a problem hiding this comment.
But we need corresponding version of react and react-dom if there is version mismatch - hooks test will fail as writtern on react website one of reason for invalid hooks is
Mismatching Versions of React and React DOM
There was a problem hiding this comment.
react and react-dom will both be 16.8 with this. RENDERER is about react-test-renderer, which doesn't necessarily have to match.
There was a problem hiding this comment.
ok , then i can use render, fireEvent, getByTestId for updating the failing test cases?
There was a problem hiding this comment.
The work that needs to be done to close the linked issue is to determine if the existing tests are valid - if so, the actual code needs to be fixed; or, if they're not valid, change them so they are valid.
There was a problem hiding this comment.
@ljharb I was going through a lot of articles the react-test-renderer before 16.8.5 have problem with shallow rendering for hooks , as they won't re-render after setting State , and we are using same the same in Adaptors so shallow won't work for version below 16.8.5,
now what we should do, modify the adaptor?
There was a problem hiding this comment.
yes, ideally we'd modify the react 16 adapter to have fallback behavior for an older renderer version.
There was a problem hiding this comment.
@AlokTakshak any interest in pursuing this fix?
There was a problem hiding this comment.
I want to but i don't have any clue of how to fix it
There was a problem hiding this comment.
My thinking is that the react 16 adapter would add some way (only for react-test-renderer prior to 16.8.5) to catch useState calls and force a rerender manually.
Codecov Report
@@ Coverage Diff @@
## master #2122 +/- ##
=======================================
Coverage 96.12% 96.12%
=======================================
Files 49 49
Lines 4004 4004
Branches 1123 1123
=======================================
Hits 3849 3849
Misses 155 155 Continue to review full report at Codecov.
|
ljharb
force-pushed
the
master
branch
4 times, most recently
from
2227326
to
0d5ead7
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
43eb75e
to
39e6b1f
Compare
Closes #2113.