WIP: add phantomjs Fixes #1144 #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
add-phantomjs
branch
from
283a05b
to
5663ffe
Compare
|
Does this run the tests in phantom, or does it just enable them to be run in phantom? Also it'd be ideal to run each browser as its own travis-ci build. |
|
@ljharb I'm not sure how to configure it exactly (I can't see anywhere where Chrome is selected as the only browser) Marking as WIP.
yup and Browserstack. |
|
@ljharb can you jump through all the hoops for getting Browserstack for OSS? |
|
@ljharb ah looks like karma tests are currently broken anyway. Will try again when they're working on master. And yes currently the tests try to run Firefox, Chrome and Phantom. |
ljharb
force-pushed
the
master
branch
3 times, most recently
from
40cc703
to
0a17404
Compare
13 tasks
13 tasks
13 tasks
ljharb
force-pushed
the
master
branch
4 times, most recently
from
2227326
to
0d5ead7
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
43eb75e
to
39e6b1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.