This repository has been archived by the owner on May 26, 2023. It is now read-only.
New opcodes #410
Open
New opcodes #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxliang01
suggested changes
Nov 6, 2020
| @@ -1301,6 +1301,42 @@ def sym_exec_ins(params, block, instr, func_call, current_func_name): | |||
| stack.insert(0, computed) | |||
| else: | |||
| raise ValueError('STACK underflow') | |||
| elif opcode == "SHL": | |||
| if len(stack) > 1: | |||
There was a problem hiding this comment.
Suggested change
| if len(stack) > 1: | |
| if len(stack) >= 2: |
For readability
| else: | ||
| raise ValueError('STACK underflow') | ||
| elif opcode == "SHR": | ||
| if len(stack) > 1: |
There was a problem hiding this comment.
Suggested change
| if len(stack) > 1: | |
| if len(stack) >= 2: |
| @@ -1549,6 +1585,19 @@ def sym_exec_ins(params, block, instr, func_call, current_func_name): | |||
| global_state["miu_i"] = current_miu_i | |||
| else: | |||
| raise ValueError('STACK underflow') | |||
| elif opcode == "EXTCODEHASH": | |||
| if len(stack) > 0: | |||
There was a problem hiding this comment.
Suggested change
| if len(stack) > 0: | |
| if len(stack) >= 1: |
| if len(stack) > 0: | ||
| global_state["pc"] = global_state["pc"] + 1 | ||
| stack.pop(0) | ||
| new_var_name = "IH_codehash" |
There was a problem hiding this comment.
For better modelling, can you create a variable for each requested address?
| @@ -1992,6 +2041,18 @@ def sym_exec_ins(params, block, instr, func_call, current_func_name): | |||
| analysis["time_dependency_bug"][last_idx] = global_state["pc"] - 1 | |||
| else: | |||
| raise ValueError('STACK underflow') | |||
| elif opcode == "CREATE2": | |||
| if len(stack) > 3: | |||
There was a problem hiding this comment.
Suggested change
| if len(stack) > 3: | |
| if len(stack) >= 4: |
| @@ -1301,6 +1301,42 @@ def sym_exec_ins(params, block, instr, func_call, current_func_name): | |||
| stack.insert(0, computed) | |||
| else: | |||
| raise ValueError('STACK underflow') | |||
| elif opcode == "SHL": | |||
| if len(stack) > 1: | |||
| global_state["pc"] = global_state["pc"] + 1 | |||
There was a problem hiding this comment.
Use += 1 for all such occurrences
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces support for new opcodes :