Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] dns: add support for SRV records in DNS lookup #6379

Closed
wants to merge 23 commits into from
Closed

[WIP] dns: add support for SRV records in DNS lookup #6379

wants to merge 23 commits into from

Commits on Jul 16, 2019

  1. Add support for SRV records in DNS lookup 

    This adds support for SRV records in DNS lookup by introducing a new
SrvInstance type which holds a regular Address::Instance object along
with priority and weight information.

Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    5dbe4cc View commit details
    Browse the repository at this point in the history

  2. Add mock method for resolveSrv 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    b8e7008 View commit details
    Browse the repository at this point in the history

  3. Drop SRV priority and weight information 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    0401016 View commit details
    Browse the repository at this point in the history

  4. Refactor callback logic to reduce duplication 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    ca67957 View commit details
    Browse the repository at this point in the history

  5. Drop duplicate utility method 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    369582c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Wire SRV resolver with upstream implementation 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    7b260d0 View commit details
    Browse the repository at this point in the history

  2. Wire SRV resolver with logical DNS cluster impl 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    2c6da1a View commit details
    Browse the repository at this point in the history

  3. Fix tests 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a302103 View commit details
    Browse the repository at this point in the history

  4. Fix format 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    9da69fd View commit details
    Browse the repository at this point in the history

  5. Update ResolveSrvCb definition 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    7c5dcdd View commit details
    Browse the repository at this point in the history

  6. Fix compilation errors 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    8f937ff View commit details
    Browse the repository at this point in the history

  7. Implement a DNS SRV resolver 

    This implements a DNS SRV resolver named envoy.srv and handles it's
dynamic registration on server startup.

Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5c42041 View commit details
    Browse the repository at this point in the history

  8. Disallow double registration of SrvResolver 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    303ccca View commit details
    Browse the repository at this point in the history

  9. Add a todo note in the Redis cluster impl 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b0dc4da View commit details
    Browse the repository at this point in the history

  10. Generate appropriate SRV URLs in DNS impls 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b4e9b37 View commit details
    Browse the repository at this point in the history

  11. Add unit tests for Utility::urlFromSocketAddress 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    dbbdfbd View commit details
    Browse the repository at this point in the history

  12. Fix DNS cluster impl tests 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    601c1f6 View commit details
    Browse the repository at this point in the history

  13. Add unit tests for SrvInstance 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    406eb1e View commit details
    Browse the repository at this point in the history

  14. Enhance utility test with specific error messages 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    b63a81c View commit details
    Browse the repository at this point in the history

  15. Wrap SrvInstanceConstSharedPtr in DnsSrvResponse 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    a8e2903 View commit details
    Browse the repository at this point in the history

  16. Minimalize labmda captures 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    dc152d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Drop specialized types and use existing ones 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    ea167bc View commit details
    Browse the repository at this point in the history

  2. Enable safe thread and memory DNS operations 

    Signed-off-by: Venil Noronha <[email protected]>
    @venilnoronha
    venilnoronha committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    6faaddd View commit details
    Browse the repository at this point in the history