Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor opt: minor optimization to the orca parser #36492

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

address comments

8a6563e
Select commit
Loading
Failed to load commit list.
Open

minor opt: minor optimization to the orca parser #36492

address comments
8a6563e
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android tests skipped Oct 10, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36492/main@8a6563e)

wbpcode @wbpcode 8a6563e #36492 merge main@17d5942

minor opt: minor optimization to the orca parser

Commit Message: minor opt: minor optimization to the orca parser
Additional Description:

By this way, the parser needn't to scan the whole header value if the header value has invalid format. And the we needn't create a copy of the header value for json format now.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Environment

Request variables

Key Value
ref ce15abb
sha 8a6563e
pr 36492
base-sha 17d5942
actor wbpcode @wbpcode
message minor opt: minor optimization to the orca parser...
started 1728527103.518116
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true