ecds: hook UDP session filters with config provider

[ohadvano]

Additional Description: Adding a new ConfigProviderManager for UDP session filters with tests. Consuming this provider for static filters. This PR does not add dynamic filters yet, will be done in next PR.
Risk Level: low
Testing: unit tests
Docs Changes: none
Release Notes: none
Platform Specific Features: none

[ohadvano]

@RyanTheOptimist could you please take this one, as you reviewed the previous?

[adisuissa]

Assigning Ryan, but please let me know if there's someone else that you wish to review this.
/assign @RyanTheOptimist

[RyanTheOptimist]

/assign @htuch
Harvey, you're a lot more familiar with xDS than I am. Can you review this?

[adisuissa]

/assign @htuch Harvey, you're a lot more familiar with xDS than I am. Can you review this?

I should probably review it, and pass it to Kuat later.
Unassigning Harvey for now.

[adisuissa]

LGTM, thanks!

/assign-from @envoyproxy/senior-maintainers

[repokitteh-read-only]

@envoyproxy/senior-maintainers assignee is @wbpcode

🐱

Caused by: a #35713 (review) was submitted by @adisuissa.

see: more, trace.

[adisuissa]

Also assigning Kuat who has lots of experience.
/assign @kyessenov

[adisuissa]

Seems that coverage needs to be improved.
See https://storage.googleapis.com/envoy-pr/02302c0/coverage/source/extensions/filters/udp/udp_proxy/index.html

Also adding @htuch for senior-maintainer stamp instead of @wbpcode who is OOO.
/assign @htuch

[ohadvano]

@kyessenov I removed the log line I added for two reasons:

1. Coverage is reduced below minimum, and I'm not sure if this scenario is reproducible in test (see 2nd reason).
2. Not sure if we would ever get there. For static filters - the filter factory validates the protobuf message, so if the config is missing, an exception will be thrown at bootstrap. On dynamic updates (not functional yet), xDS will also throw an exception if config update is invalid (factory will also try to instantiate the filter and fail)

[ohadvano]

@adisuissa did you mean to assign @htuch?
No senior maintainer is currently assigned

[adisuissa]

@adisuissa did you mean to assign @htuch? No senior maintainer is currently assigned

Nope.. race between repokitteh and github's UI. sorry.

[kyessenov]

@kyessenov I removed the log line I added for two reasons:

1. Coverage is reduced below minimum, and I'm not sure if this scenario is reproducible in test (see 2nd reason).
2. Not sure if we would ever get there. For static filters - the filter factory validates the protobuf message, so if the config is missing, an exception will be thrown at bootstrap. On dynamic updates (not functional yet), xDS will also throw an exception if config update is invalid (factory will also try to instantiate the filter and fail)

This path used when ECDS fails to push config and the parent LDS was not configured to warm on ECDS. I think we have to handle this case, but I'm OK waiting till the final integration.

[ohadvano]

I see, makes sense. I'll add it back in the dynamic configs PR with test that would be able to cover it using ECDS

[ohadvano]

Harvey, thanks for all your dedication, contribution and guidance it's very much appreciated.
Will unassign due to you moving to emeritus maintainer.

/unassign @htuch
/assign-from @envoyproxy/senior-maintainers

[repokitteh-read-only]

@envoyproxy/senior-maintainers assignee is @yanavlasov

🐱

Caused by: a #35713 (comment) was created by @ohadvano.

see: more, trace.