access log: added new START_TIME_LOCAL & EMIT_TIME_LOCAL command #35280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: doujiang24 <[email protected]>
|
PTAL cc @wbpcode Thanks. |
|
In order to review this PR, we check the code of I will inclined to fix that bug first. And I think it will simply this PR. /wait-any |
wbpcode
reviewed
Jul 26, 2024
|
/wait |
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
|
@wbpcode Thanks and sorry for the late. Here are the benchmark results: |
wbpcode
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Thanks for the update. It's near there. Some comments are added.
And you may could add a simple speed test in the utility_speed_test.cc for the AccessLogDateTimeFormatter::fromTime with local time zone.
(I guess it won't bring much effect because there is only some additional bool check, but this is a performance sensitive feature anyway, a test would be better)
Signed-off-by: doujiang24 <[email protected]>
Signed-off-by: doujiang24 <[email protected]>
wbpcode
approved these changes
Jul 31, 2024
|
LGTM. Thanks. |
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
…oyproxy#35280) Commit Message: access log: added new START_TIME_LOCAL & EMIT_TIME_LOCAL command Additional Description: Same as START_TIME & EMIT_TIME, but use local time zone. close envoyproxy#35116 Risk Level: low. Testing: unit. Docs Changes: added. Release Notes: TODO. Platform Specific Features: n/a. --------- Signed-off-by: doujiang24 <[email protected]> Signed-off-by: Martin Duke <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…oyproxy#35280) Commit Message: access log: added new START_TIME_LOCAL & EMIT_TIME_LOCAL command Additional Description: Same as START_TIME & EMIT_TIME, but use local time zone. close envoyproxy#35116 Risk Level: low. Testing: unit. Docs Changes: added. Release Notes: TODO. Platform Specific Features: n/a. --------- Signed-off-by: doujiang24 <[email protected]> Signed-off-by: asingh-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: access log: added new START_TIME_LOCAL & EMIT_TIME_LOCAL command
Additional Description:
Same as START_TIME & EMIT_TIME, but use local time zone.
close #35116
Risk Level: low.
Testing: unit.
Docs Changes: added.
Release Notes: TODO.
Platform Specific Features: n/a.