Credential injection dual filter support #35194
Conversation
Signed-off-by: Juan Manuel Ollé <[email protected]>
|
I would like to have feedback before proceed with unit test and integration tests |
| hdrs = ["server_factory_context.h"], | ||
| srcs = [ | ||
| "server_factory_context.cc", | ||
| "transport_socket_factory_context.cc", |
There was a problem hiding this comment.
this is to avoid circular dependencies between both mocks. probably it should be only one.
Signed-off-by: Juan Manuel Ollé <[email protected]>
|
/retest |
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
| @@ -1045,8 +1045,10 @@ void ClusterManagerImpl::updateClusterCounts() { | |||
| } | |||
|
|
|||
| ThreadLocalCluster* ClusterManagerImpl::getThreadLocalCluster(absl::string_view cluster) { | |||
| if (!tls_.get()) { | |||
| return nullptr; | |||
| } | |||
There was a problem hiding this comment.
during upstream filter initialization, the filter tries to do a warmup and perform a request. this object is not initialized at that moment. Is there a better solution for this?
| FilterConfigSharedPtr config = std::make_shared<FilterConfig>( | ||
| std::move(credential_injector), proto_config.overwrite(), | ||
| proto_config.allow_request_without_credential(), | ||
| dual_info.is_upstream ? "credential_injector." : stats_prefix + "credential_injector.", |
There was a problem hiding this comment.
this is another side effect, it is called twice. without this change we get cluster.cluster_0.cluster.cluster_0credential_injector
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
Signed-off-by: Juan Manuel Ollé <[email protected]>
|
/wait-any |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Convert credential injection filter in dual filter
Risk Level: low
Testing: yes
Docs Changes: n/a
Release Notes: yes
Platform Specific Features: No