stream info: add bool string serlalizer (#36451)

Change-Id: I2065f5ed863ca4b6b439f00dc39de0dcdbe2eb4c Commit Message: add missing serializer for bool object. I discovered this gap while using Wasm `get_property`. Risk Level: low Testing: yes Signed-off-by: Kuat Yessenov <[email protected]>
envoyproxy · Oct 7, 2024 · fc10098 · fc10098
1 parent 0aff211
commit fc10098
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/source/common/stream_info/bool_accessor_impl.h b/source/common/stream_info/bool_accessor_impl.h
@@ -19,6 +19,10 @@ class BoolAccessorImpl : public BoolAccessor {
     return message;
   }
 
+  absl::optional<std::string> serializeAsString() const override {
+    return value_ ? "true" : "false";
+  }
+
   // From BoolAccessor.
   bool value() const override { return value_; }
 

diff --git a/test/common/stream_info/bool_accessor_impl_test.cc b/test/common/stream_info/bool_accessor_impl_test.cc
@@ -22,6 +22,12 @@ TEST(BoolAccessorImplTest, TestProto) {
   EXPECT_NE(nullptr, message);
 }
 
+TEST(BoolAccessorImplTest, TestString) {
+  BoolAccessorImpl accessor(true);
+  auto str = accessor.serializeAsString();
+  EXPECT_EQ("true", str);
+}
+
 } // namespace
 } // namespace StreamInfo
 } // namespace Envoy