Skip to content

Commit

Permalink
tls: fix merge issues due to server_context refactoring
Browse files Browse the repository at this point in the history
Signed-off-by: Arul Thileeban Sagayam <[email protected]>
  • Loading branch information
arulthileeban committed Jul 21, 2024
1 parent eae5cff commit 96ec715
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion source/common/tls/server_context_config_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ ServerContextConfigImpl::ServerContextConfigImpl(
disable_stateless_session_resumption_(getStatelessSessionResumptionDisabled(config)),
disable_stateful_session_resumption_(config.disable_stateful_session_resumption()),
full_scan_certs_on_sni_mismatch_(
PROTOBUF_GET_WRAPPED_OR_DEFAULT(config, full_scan_certs_on_sni_mismatch, false)) {
PROTOBUF_GET_WRAPPED_OR_DEFAULT(config, full_scan_certs_on_sni_mismatch, false)),
prefer_client_ciphers_(config.prefer_client_ciphers()) {
SET_AND_RETURN_IF_NOT_OK(creation_status, creation_status);
if (session_ticket_keys_provider_ != nullptr) {
// Validate tls session ticket keys early to reject bad sds updates.
Expand Down
2 changes: 2 additions & 0 deletions source/common/tls/server_context_config_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class ServerContextConfigImpl : public ContextConfigImpl, public Envoy::Ssl::Ser
}

bool fullScanCertsOnSNIMismatch() const override { return full_scan_certs_on_sni_mismatch_; }
bool preferClientCiphers() const override { return prefer_client_ciphers_; }

private:
ServerContextConfigImpl(
Expand Down Expand Up @@ -71,6 +72,7 @@ class ServerContextConfigImpl : public ContextConfigImpl, public Envoy::Ssl::Ser
const bool disable_stateless_session_resumption_;
const bool disable_stateful_session_resumption_;
bool full_scan_certs_on_sni_mismatch_;
const bool prefer_client_ciphers_;
};

} // namespace Tls
Expand Down

0 comments on commit 96ec715

Please sign in to comment.