more coverage

Signed-off-by: Takeshi Yoneda <[email protected]>
envoyproxy · Oct 5, 2024 · 7eeece9 · 7eeece9
1 parent 9356053
commit 7eeece9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/test/extensions/dynamic_modules/http/BUILD b/test/extensions/dynamic_modules/http/BUILD
@@ -34,5 +34,6 @@ envoy_cc_test(
         "//source/extensions/filters/http/dynamic_modules:filter_lib",
         "//test/extensions/dynamic_modules:util",
         "//test/mocks/http:http_mocks",
+        "//test/mocks/server:server_mocks",
     ],
 )
diff --git a/test/extensions/dynamic_modules/http/filter_test.cc b/test/extensions/dynamic_modules/http/filter_test.cc
@@ -1,6 +1,7 @@
 #include "source/extensions/filters/http/dynamic_modules/filter.h"
 
 #include "test/extensions/dynamic_modules/util.h"
+#include "test/mocks/http/mocks.h"
 #include "test/test_common/utility.h"
 
 namespace Envoy {
@@ -27,7 +28,11 @@ TEST_P(DynamicModuleTestLanguages, Nop) {
       std::make_shared<Envoy::Extensions::DynamicModules::HttpFilters::DynamicModuleHttpFilter>(
           filter_config_ptr);
 
-  // The followings are for mostly coverage at the moment.
+  // The followings are mostly for coverage at the moment.
+  NiceMock<Http::MockStreamDecoderFilterCallbacks> decoder_callbacks;
+  filter->setDecoderFilterCallbacks(decoder_callbacks);
+  NiceMock<Http::MockStreamEncoderFilterCallbacks> encoder_callbacks;
+  filter->setEncoderFilterCallbacks(encoder_callbacks);
   filter->onStreamComplete();
   filter->onDestroy();
   TestRequestHeaderMapImpl headers{{}};